Conversation
The login hook restores the pinned session before running Codex. When auth.json was still a symlink to the saved snapshot and the pinned snapshot already matched, restore skipped activation and left the symlink in place. Official codex login could then write through the symlink and replace the saved admin snapshot with the newly logged-in account. Materialize auth.json during restore before the identity-match early return so Codex writes only to the working auth file. The regression keeps the snapshot symlink case and simulates an official login writing Odin credentials after restore. Constraint: Existing installations may still have symlinked auth.json from older versions. Rejected: Only rely on syncExternalAuthSnapshotIfNeeded after Codex exits | the snapshot is already overwritten by then. Confidence: high Scope-risk: narrow Directive: Restore-session must keep auth.json as a regular file before launching Codex. Tested: npm test Tested: npm test -- --test-name-pattern 'restoreSessionSnapshotIfNeeded materializes matching auth symlink' Tested: openspec validate --specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).